[ResponseOps] Rename some alert -> rule terminology in the code #178988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doakalexi
changed the title
|
/ci |
doakalexi
added
Team:ResponseOps
doakalexi
changed the title
…bana into tech-debt/alert-rule-change
|
/ci |
…bana into tech-debt/alert-rule-change
|
/ci |
|
/ci |
|
Pinging @elastic/response-ops (Team:ResponseOps) |
ymao1
reviewed
Mar 20, 2024
| @@ -90,6 +90,6 @@ export const INTERNAL_ALERTING_API_MAINTENANCE_WINDOW_PATH = | |||
| export const INTERNAL_ALERTING_API_GET_ACTIVE_MAINTENANCE_WINDOWS_PATH = | |||
| `${INTERNAL_ALERTING_API_MAINTENANCE_WINDOW_PATH}/_active` as const; | |||
|
|
|||
| export const ALERTS_FEATURE_ID = 'alerts'; | |||
| export const RULES_FEATURE_ID = 'alerts'; | |||
There was a problem hiding this comment.
I think this should actually be ALERTING_FEATURE_ID because this is the alerting plugin (it used to be the alerts plugin)
There was a problem hiding this comment.
oh okay, thanks! I will update it
There was a problem hiding this comment.
Resolved in this commit ea9313d
botelastic
bot
added
the
Team:obs-ux-management
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @doakalexi |
maryam-saeidi
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #168861
Summary
This is a tech debt issue that I made a little progress on, I made some changes to rename alert -> rule. It's an ongoing task, but I made a PR for my changes so I can release the issue back to the iteration.
Nothing to verify, just make sure that the build passes.